Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

series: add exercise #346

Merged
merged 1 commit into from
Sep 12, 2024
Merged

series: add exercise #346

merged 1 commit into from
Sep 12, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from a team September 11, 2024 17:37
@colinleach
Copy link
Contributor

colinleach commented Sep 11, 2024

The R track has a particularly fierce linter. We all get caught by this the first few times!

This looks like a good addition, once we placate the linter.

@ErikSchierboom
Copy link
Member Author

I've updated the PR

"uuid": "2ef6f027-a27c-4b00-bf1e-2969baf04a36",
"practices": [],
"prerequisites": [],
"difficulty": 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"difficulty": 3
"difficulty": 3,
"topics": [
"strings"
]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine adding this, but you do know that topics aren't used by the website, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, it did cross my mind that if you hadn't included it, it was quite likely because it's not really needed or being used anywhere, but was more efficient for me to suggest it and wait and see how you responded than for me to try and check if or how it might be used later. If there's no value in adding it (now or for later) then obviously fine with leaving it out.

Copy link
Member

@jonmcalder jonmcalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErikSchierboom ErikSchierboom merged commit 8e8a4e2 into main Sep 12, 2024
3 checks passed
@ErikSchierboom ErikSchierboom deleted the series-exercise branch September 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants